Fix CLI Hindcast by Consuming Generator - #56
Merged
Conversation
mxkpp
force-pushed
the
maxkipp-fix-cli-hindcast
branch
from
July 29, 2026 02:34
7727fd9 to
01ecd79
Compare
jswade-rtx
approved these changes
Jul 29, 2026
jswade-rtx
left a comment
jswade-rtx
left a comment
There was a problem hiding this comment.
Changes look good. Successfully tested a hindcast from the CLI in the RTE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI hindcast was inadvertently broken during #43 since it was not adapted to consume the generator
run_hindcast, which previously had been a regular function. It had been changed to be a generator for a nwm-rte use case. This fixes that regression for the CLI use case.